RFR [1/7]: 8197569: Refactor eager reclaim for concurrent remembered set rebuilding (original) (raw)

Stefan Johansson stefan.johansson at oracle.com
Mon Mar 5 15:11:53 UTC 2018

Thanks for splitting this change up Thomas,

On 2018-03-05 15:18, Thomas Schatzl wrote:

Hi all,

can I have some reviews for the following change that refactors the eager reclaim condition so that it can be later used for the policy that determines for which regions G1 should rebuild the remembered set? (And it's a reasonable refactoring on its own btw). CR: https://bugs.openjdk.java.net/browse/JDK-8197569 Webrev: http://cr.openjdk.java.net/~tschatzl/8197569/webrev/ Look good, just one thing: src/hotspot/share/gc/g1/g1CollectedHeap.cpp 2542   bool humongous_region_is_candidate(G1CollectedHeap* heap, HeapRegion* region) const { ... 2594     return obj->is_typeArray() && 2595 G1CollectedHeap::heap()->is_potential_eager_reclaim_candidate(region);

You could use the passed in heap parameter instead of using G1CollectedHeap::heap(). Another, maybe even nicer, solution would be to move is_potential_eager_reclaim_candidate() to HeapRegion, and just call region->is_potential_eager_reclaim_candidate().

Thanks, Stefan

Testing: hs-tier 1-5, mostly as part of other related changes

Thanks, Thomas

More information about the hotspot-gc-dev mailing list