RFR: 8197852: Move G1DefaultPolicy into G1Policy (original) (raw)

Erik Helin erik.helin at oracle.com
Wed Mar 7 10:39:44 UTC 2018

On 03/07/2018 11:04 AM, Thomas Schatzl wrote:

Hi,

On Mon, 2018-03-05 at 16:02 +0100, Erik Helin wrote: Hi all,

this fairly small patch re-unites G1Policy and G1DefaultPolicy, there is no need for having both classes. With this patch we only have G1Policy (and of course G1CollectorPolicy as the little CollectorPolicy shim). Issue: https://bugs.openjdk.java.net/browse/JDK-8197852 Patch: http://cr.openjdk.java.net/~ehelin/8197852/00/ Testing: - make run-test-tier1 on Linux, Windows, Mac, Solaris (SPARC and x86- 64) in g1Policy.hpp, if you update the copyright notice, please use the correct year (2018) :)

Oops, my bad, I will fix before I push :)

Is there a way to move g1DefaultPolicy.hpp into g1Policy.hpp while retaining history? I.e. delete the latter first, and then rename?

Yep, the commit does that, it is just not reflected in the webrev. The "trick" is to hg mv g1DefaultPolicy.hpp g1Policy.hpp and then make the changes, that keeps the history.

Thanks, Erik

I do not need to re-review this change.

Thanks, Thomas

More information about the hotspot-gc-dev mailing list