RFR: JDK-8199620: Support for JNI object pinning (original) (raw)

Thomas Schatzl thomas.schatzl at oracle.com
Tue Mar 20 10:28:18 UTC 2018

Hi,

On Mon, 2018-03-19 at 18:07 +0100, Roman Kennke wrote:

Hi Erik,

thanks for reviewing! I can do that, but a GC would get the opportunity to do both, or one or the other in any case. As it stands, the JNI side of the GCLocker protocol is always executed. If a GC decides to participate in GCLocker protocol, by calling GCLocker::checkactivebeforegc() and related API, then will get JNI Critical function support, otherwise GCLocker is basically counting up and down counters. If it instead wishes to use pinning and ignore JNI critical functions, then it only needs to override the pinning methods and not participate in GCLocker, and everything would be fine. However, I don't mind either way, so here's the alternative: Diff: http://cr.openjdk.java.net/~rkennke/8199620/webrev.02.diff/ Full: http://cr.openjdk.java.net/~rkennke/8199620/webrev.02/ Better?

I also prefer this version. Looks good.

Thanks, Thomas

More information about the hotspot-gc-dev mailing list