RFR: 8199918: Shorten names of CollectedHeap::Name members (original) (raw)
Aleksey Shipilev shade at redhat.com
Wed Mar 21 14:00:45 UTC 2018
- Previous message (by thread): RFR: 8199918: Shorten names of CollectedHeap::Name members
- Next message (by thread): RFR: 8199918: Shorten names of CollectedHeap::Name members
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On 03/21/2018 02:57 PM, Per Liden wrote:
Thanks for reviewing.
Updated webrev: http://cr.openjdk.java.net/~pliden/8199918/webrev.0vs1 http://cr.openjdk.java.net/~pliden/8199918/webrev.1
Looks good.
Should it be "Invalid kind", not "Invalid name"? Maybe "kind()" is tripping me off, and it clashes with "name()" that returns char*. It is a minor nit, your call if you want to keep it this way.
-Aleksey
-------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: OpenPGP digital signature URL: <https://mail.openjdk.org/pipermail/hotspot-gc-dev/attachments/20180321/a24ff5c8/signature.asc>
- Previous message (by thread): RFR: 8199918: Shorten names of CollectedHeap::Name members
- Next message (by thread): RFR: 8199918: Shorten names of CollectedHeap::Name members
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]