RFR (S): 8196485: FromCardCache default card index can cause crashes (original) (raw)

Aleksey Shipilev shade at redhat.com
Fri Mar 23 08:45:42 UTC 2018

On 03/08/2018 09:59 AM, Thomas Schatzl wrote:

CR: https://bugs.openjdk.java.net/browse/JDK-8196485 Webrev: http://cr.openjdk.java.net/~tschatzl/8196485/webrev/

Ha! Ouch. Looks good, except:

*) I feel uneasy about assigning negative values to unsigned vars. Intended to be UINTPTR_MAX?

static const uintptr_t InvalidCard = -1;

*) "heap region" here, probably:

134 // of the given heapregion.

Thanks, -Aleksey

-------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: OpenPGP digital signature URL: <https://mail.openjdk.org/pipermail/hotspot-gc-dev/attachments/20180323/d843b8f2/signature.asc>

More information about the hotspot-gc-dev mailing list