RFR: 8199850: Move parsing of VerifyGCType to G1 (original) (raw)

Stefan Johansson stefan.johansson at oracle.com
Fri Mar 23 09:38:25 UTC 2018

On 2018-03-23 10:27, Per Liden wrote:

Hi Thomas,

On 03/22/2018 05:20 PM, Thomas Schatzl wrote: Hi,

On Tue, 2018-03-20 at 10:11 +0100, Per Liden wrote: When JDK-8191821 introduced the VerifyGCType option for G1 I didn't quite see the need for this to affect the GCArguments class. I'm proposing we move this logic into G1HeapVerifier, which I believe is a better place for this. I would actually prefer this parsing to be located and called by the G1Arguments class. I really dislike the (existing) G1 habit of every class doing its own arguments parsing. It's much more convenient to have one place to look at compared to first searching where it's actually parsed. I do agree that since it is not supported by other collectors (yet?) the shared code may not be the perfect place for it. However if others disagree, keep it this way. No problem. Here's an updated webrev, which moves the arguments parsing logic to G1Arguments. http://cr.openjdk.java.net/~pliden/8199850/webrev.1 Looks better :) Thanks, Stefan

/Per

Bug: https://bugs.openjdk.java.net/browse/JDK-8199850 Webrev: http://cr.openjdk.java.net/~pliden/8199850/webrev.0 Testing: Used gc/g1/TestVerifyGCType.java to verify that nothing broke (I assume you executed it directly as it is currently problemlisted) Thanks, Thomas

More information about the hotspot-gc-dev mailing list