RFR (M): 8151171: Bring g1ConcurrentMark files up to current coding conventions (original) (raw)

sangheon.kim sangheon.kim at oracle.com
Wed Mar 28 17:43:19 UTC 2018

Hi Thomas,

On 03/28/2018 05:21 AM, Thomas Schatzl wrote:

Hi Stefan,

On Wed, 2018-03-28 at 13:26 +0200, Stefan Johansson wrote: Hi Thomas,

Very nice cleanup. thanks for your review. On 2018-03-26 17:14, Thomas Schatzl wrote: Hi all,

can I have reviews for this mostly renaming patch that cleans up g1ConcurrentMark files (once again sigh). Changes: - camelCase variable and method naming - missing brackets around one-line if-statement bodies. - method naming (getters/setters) - use g1h member variable instead of g1 or another method local variable as discussed earlier - use assertatsafepoint* macros - remove incomprehensible comments - changed "CheckPointRoots" to "Remark" throughout ... CR: https://bugs.openjdk.java.net/browse/JDK-8151171 Webrev: http://cr.openjdk.java.net/~tschatzl/8151171/webrev Looks good, just to have one comment ;) src/hotspot/share/gc/g1/concurrentMarkThread.cpp 331 CMRemark finalcl(cm); 362 CMCleanup clcl(cm); Rename the instances to remark and cleanup. :) Done. http://cr.openjdk.java.net/~tschatzl/8151171/webrev.0to1 (diff) http://cr.openjdk.java.net/~tschatzl/8151171/webrev.1 (full) Webrev.1 looks good to me.

It would be better to update copyright year for concurrentMarkThread.hpp before pushing it.

Thanks, Sangheon

I found some more (very minor) renaming work to be done in concurrentMarkThread.[hc]pp. Nothing really fancy. Thanks, Thomas

More information about the hotspot-gc-dev mailing list