RFR (S): 8200255: Remove G1CMTask::_concurrent (original) (raw)

sangheon.kim sangheon.kim at oracle.com
Wed Mar 28 17:45:38 UTC 2018


Hi Thomas,

On 03/26/2018 11:25 AM, Thomas Schatzl wrote:

Hi all,

can I have reviews for this small change that removes G1CMTask::concurrent. That member is a duplicate of G1ConcurrentMark::concurrent, but there does not seem to be any advantage of keeping this duplicate, as it's only used in asserts or non-performance critical code. This removes some imho unnecessary code, so I suggest to do that. CR: https://bugs.openjdk.java.net/browse/JDK-8200255 Webrev: http://cr.openjdk.java.net/~tschatzl/8200255/webrev/ Testing: local compilation, gcbasher, testing with other changes Looks good to me too.

Thanks, Sangheon

Thanks, Thomas



More information about the hotspot-gc-dev mailing list