RFR(XXS): 8214125: [test] Fix comparison between pointer and integer in test_ptrQueueBufferAllocator.cpp (original) (raw)

Volker Simonis volker.simonis at gmail.com
Tue Nov 20 18:09:12 UTC 2018

Thanks everybody for the quick reviews!

I've successfully run this change through the submit repo and pushed it.

Best regards, Volker

On Tue, Nov 20, 2018 at 5:40 PM Thomas Stüfe <thomas.stuefe at gmail.com> wrote:

Looks good and trivial. I remember running into this before, see 8171225. What I do not understand is, should NULL not be (void*)0 according to Posix: http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/stddef.h.html ? So this should be a pointer-pointer comparison. Maybe we just miss include <stddef.h> somehow on AIX? .. Thomas On Tue, Nov 20, 2018, 17:03 Volker Simonis <volker.simonis at gmail.com wrote:

Hi, can I please have a review fort he following trivial gtest fix which currently breaks the AIX build: http://cr.openjdk.java.net/~simonis/webrevs/2018/8214125/ https://bugs.openjdk.java.net/browse/JDK-8214125 Change JDK-8213352 introduced an gtest which does a comparison between an integer and a pointer which is forbidden in C++: ASSERTEQ(NULL, nodes[i]->next()); I don't know why other compilers havn't complained about it, but XLC did. The fix for this is trivial - just cast NULL to the appropriate pointer type: ASSERTEQ((BufferNode*)NULL, nodes[i]->next());

Thank you and best regards, Volker

More information about the hotspot-gc-dev mailing list