RFR(M): 8140482: Various minor code improvements (runtime) (original) (raw)

Lindenmaier, Goetz goetz.lindenmaier at sap.com
Mon Nov 2 11:13:34 UTC 2015

Hi,

could someone please have a look at this issue?

Thanks! Goetz.

From: Lindenmaier, Goetz Sent: Dienstag, 27. Oktober 2015 08:40 To: hotspot-runtime-dev at openjdk.java.net Subject: RFR(M): 8140482: Various minor code improvements (runtime)

Hi,

SAP requires us to fix a row of issues in hotspot. I'd like to share these with openjdk: http://cr.openjdk.java.net/~goetz/webrevs/8140482-covRt/webrev.00

Please review this change. I please need a sponsor.

The fixes in detail:

libproc_impl.c: Do strncpy in case getenv returned a bad string. Strcat could overflow the buffer. Use strncat instead.

ps_core.c: Pread not necessarily terminates interp_name which is printed thereafter. Increase buffer size by 1 and add '\0'.

stubRoutines_x86.cpp: Cast to proper type. This way, left and right of '&' have the same type.

attachListener_linux.cpp: Read does not terminate buf. Size for '\0' is already considered.

os_linux.cpp: Array sigflags[] has size MAXSIGNUM==32. _NSIG is bigger than MAXSIGNUM (_NSIG == 65 on my machine). sig is checked to be smaller than _NSIG. Later, in set_our_sigflags(), sig is used to access sigflags[MAXSIGNUM] which can overflow the array. Should we also increase MAXSIGNUM? os::get_core_path(): read does not terminate string, but strlen is called on it. The size already foresees one char for the '\0' byte.

codeBuffer.cpp: New_capacity is not initialized. Figure_expanded_capacities() handles this correctly, but initializing this is cheap and safe.

dict.cpp: If j-- is executed for j==0, the loop aborts because j is unsigned (0-- >= b->_cnt). Instead, only do j++ if necessary.

generateOopMap.cpp: Idx is read from String. This is only called with constant strings, so compare should be folded away by optimizing compilers if inlined.

deoptimization.cpp: If buflen == 0, buf[-1] is accessed.

task.cpp: Fatal can return if -XX:SuppressErrorAt is used. Just don't access the array in this case.

attachListener.hpp: Do strncpy to not overflow buffer. Don't write more chars than before.

heapDumper.cpp: strncpy does not null terminate.

Some of these, as the issue in codeBuffer.cpp, are actually handled correctly. Nevertheless this is not that obvious so that somebody changing the code Could oversee he has to add the initialization.

Some of these fixes are part of SAP JVM for a long time. This change has been tested with our nightly build of openJDK.

Best regards, Goetz,.

More information about the hotspot-runtime-dev mailing list