JDK-8133416: [TESTBUG] Remove @ignore for closed/runtime/4345157/Prog.java (original) (raw)

Dmitry Dmitriev dmitry.dmitriev at oracle.com
Thu Nov 5 13:21:35 UTC 2015

Hi Stas,

Looks good to me. Only few comments:

  1. test/runtime/ThreadSignalMask/exeThreadSignalMask.c module

Line 81: Place for a comment seems strange, probably put it before function? Line 87: Remove commented code. Line 88: Comment at the end seems wrong.

I don't need a new webrev for that changes.

Thanks, Dmitry

On 04.11.2015 13:33, Stas Smirnov wrote:

Hello,

please review this fix for JDK-8133416. The test has been fixed and rewritten in Java to start using native support mechanism in Jtreg. Also, its native part has been modified to avoid compilation on inappropriate platforms and also includes improvements. Unfortunately the JBS issue is not visible to the community as well as the original version of the test sources. JBS: https://bugs.openjdk.java.net/browse/JDK-8133416 webrev: http://cr.openjdk.java.net/~stsmirno/8133416/webrev.00 Tested: the fix has been tested on all platforms with the hotspot/test/runtime testset

More information about the hotspot-runtime-dev mailing list