RFR (S) 8079408 - Improve class loading log (with unified logging) (original) (raw)
Coleen Phillimore coleen.phillimore at oracle.com
Tue Nov 10 23:39:50 UTC 2015
- Previous message: RFR (S) 8079408 - Improve class loading log (with unified logging)
- Next message: RFR (S) 8079408 - Improve class loading log (with unified logging)
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Ioi, Nice logging conversion.
- if (log_is_enabled(Debug, classload)) {
outputStream* log = LogHandle(classload)::debug_stream();log->print_cr("[Opened %s]", path);- }
There's no reason to do this. You can replace simply with one line: log_debug(classload)("[Opened %s]", path);
What you have is testing whether log_is_enabled for Debug/classload tag twice and it's 4 lines and a conditional rather than one line.
Same comment:
if (log_is_enabled(Trace, classloaderdata) && class_loader() != NULL) {outputStream* log = LogHandle(classloaderdata)::trace_stream();log->print_cr("is_anonymous: %s", class_loader()->klass()->internal_name(
I think this would be neater as:
if (class_loader() != NULL) {log_trace(classloaderdata)("is_anonymous: %s", class_loader()->klass()->internal_name(
For two of these.
Can you make the logging code a new function, rather than glomming it on the end of the function?
In your function you can pause the nosafepoint verifier instead.
Pause_No_Safepoint_Verifier pnsv(&_nsv);Same comment.
- if (log_is_enabled(Debug, classload)) {
this_klass()->print_loading_log(LogLevel::Debug, loader_data, cfs);- }
- if (log_is_enabled(Trace, classload)) {
this_klass()->print_loading_log(LogLevel::Trace, loader_data, cfs);- }
I think this should be
- if (log_is_enabled(Debug, classload)) {
this_klass()->print_loading_log(loader_data, cfs);
and then check for trace level inside of print_loading_log (debug will include trace, I believe).
Coleen
On 11/9/15 6:49 PM, Ioi Lam wrote:
Please review a small fix, related to unified logging:
http://cr.openjdk.java.net/~iklam/8079408-improve-class-load-log/ Bug: 8079408 Improve class loading log (with unified logging) https://bugs.openjdk.java.net/browse/JDK-8079408 Summary of fix: This fix has 2 parts: [a] Reimplement TraceClassData and TraceClassLoading as -Xlog:classloaderdata and -Xlog:classload [b] Add more detailed info to -Xlog:classload so we can perform more analysis Example: _java -Xlog:classloaderdata=debug,classload=trace:file=log.txt _ -cp ~/tests Hello I have completely replaced TraceClassData with -Xlog:classloaderdata. The TraceClassData flag has been removed from globals.hpp. Since many existing tools use TraceClassLoading, I think it's better to deprecate it, but otherwise don't change how it works. Instead, we add a new -Xlog:classload flag that's independent of the old TraceClassLoading flag. (note: the deprecation of TraceClassLoading will be done in a separate bug). I have also not tied "-verbose:class" with the classload log, since I think "-verbose:class" is obsolete and should be replaced by -Xlog. Tests: RBT: I ran these testlists using RBT (more than 20000 total classes on Linux/Windows/MacOS/solaris) and saw no new failures. I think this means no existing tests depend on the removed -XX:+TraceClassLoaderData flag. hotspot/test/:hotspotall vm.parallelclassloading.testlist vm.regression.testlist vm.runtime.testlist vm.tmtools.testlist nsk.sajdi.testlist nsk.stress.testlist nsk.stress.jck.testlist vm.gc.testlist vm.metaspace.testlist Thanks - Ioi
- Previous message: RFR (S) 8079408 - Improve class loading log (with unified logging)
- Next message: RFR (S) 8079408 - Improve class loading log (with unified logging)
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]