RFR: 8143229: Replace the develop level with develop macros in Unified Logging (original) (raw)
Rachel Protacio rachel.protacio at oracle.com
Fri Nov 20 22:11:21 UTC 2015
- Previous message: RFR: 8143229: Replace the develop level with develop macros in Unified Logging
- Next message: RFR: 8143229: Replace the develop level with develop macros in Unified Logging
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Aside from Coleen's question, looks good to me! Thanks for doing this. Rachel
On 11/20/2015 4:58 PM, Coleen Phillimore wrote:
Hi Marcus, This looks good, except I have one question: http://cr.openjdk.java.net/~mlarsson/8143229/webrev.00/src/share/vm/logging/logConfiguration.cpp.udiff.html
Shouldn't this be logdevelopinfo(logging) not trace? Why did you pick trace? thanks, Coleen On 11/20/15 6:58 AM, Marcus Larsson wrote: Hi,
Please review the following patch to replace the previous 'develop' level with macros, in the unified logging framework. The macros are essentially regular log calls inside a #ifndef PRODUCT. In the product they do nothing / return false. This allows the regular log levels to be used for develop-only logging. Webrev: http://cr.openjdk.java.net/~mlarsson/8143229/webrev.00/ Issue: https://bugs.openjdk.java.net/browse/JDK-8143229 Thanks, Marcus
- Previous message: RFR: 8143229: Replace the develop level with develop macros in Unified Logging
- Next message: RFR: 8143229: Replace the develop level with develop macros in Unified Logging
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]