RFR(S): aarch64 Fix loading ConstantPoolCacheEntry._indices with load acquire (original) (raw)
Andrew Haley aph at redhat.com
Sat Nov 21 10:42:02 UTC 2015
- Previous message: RFR(S): aarch64 Fix loading ConstantPoolCacheEntry._indices with load acquire
- Next message: [aarch64-port-dev ] RFR(S): aarch64 Fix loading ConstantPoolCacheEntry._indices with load acquire
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
The patch looks good.
I suggest some minor changes.
// n.b. unlike x86 cache alreeady includes the index offset
Please correct to "already"
This
ldrw(bytecode, Address(cache, ConstantPoolCache::base_offset() + ConstantPoolCacheEntry::indices_offset()));
could simply be changed to
lea(bytecode, Address(cache, ConstantPoolCache::base_offset() + ConstantPoolCacheEntry::indices_offset())); ldarw(bytecode, bytecode);
which would be more idiomatic for this port. It generates the same code.
Andrew.
- Previous message: RFR(S): aarch64 Fix loading ConstantPoolCacheEntry._indices with load acquire
- Next message: [aarch64-port-dev ] RFR(S): aarch64 Fix loading ConstantPoolCacheEntry._indices with load acquire
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]