[aarch64-port-dev ] RFR: JDK-8143584 Aarch64: Load constant pool tag and class status with load acquire (original) (raw)

Hui Shi hui.shi at linaro.org
Thu Nov 26 12:59:17 UTC 2015


As Andrew still in JDK9 reviewer nomination process :)

Could I have an official reviewer and sponsor for this aarch64 runtime change?

Regards Hui

On 25 November 2015 at 21:21, Hui Shi <hui.shi at linaro.org> wrote:

Thanks!

Yes, I see layouthelper is initialized with slowpath flag in InstanceKlass constructor. // Set temporary value until parseClassFile updates it with the real instance // size. setlayouthelper(Klass::instancelayouthelper(0, true)); Regards Shi Hui On 25 November 2015 at 20:09, Andrew Haley <aph at redhat.com> wrote:

On 11/25/2015 11:28 AM, Hui Shi wrote: > > I haven't find explicit code synchronize InstanceKlass' content. In > SystemDictionary::loadinstanceclass, it uses MutexLocker and this might > help.

We don't need to synchronize in TemplateTable::new because Klass::layouthelper saves the slowpath flag in the least significant bit. If we find that layouthelper is not valid we'll take the slow path and acquire the lock. > new webrev in http://cr.openjdk.java.net/~hshi/8143584/webrevv2/ That looks OK. Thanks, Andrew.



More information about the hotspot-runtime-dev mailing list