RFR: JDK-8138574: [TESTBUG] TestBasicLogOutput.java doesn't account for padding (original) (raw)
Rachel Protacio rachel.protacio at oracle.com
Thu Oct 1 14:43:05 UTC 2015
- Previous message: RFR: JDK-8138574: [TESTBUG] TestBasicLogOutput.java doesn't account for padding
- Next message: RFR: JDK-8138574: [TESTBUG] TestBasicLogOutput.java doesn't account for padding
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Thank you, Harold, Rachel
On 10/1/2015 10:40 AM, harold seigel wrote:
Hi Rachel,
This change looks good. Harold On 9/30/2015 4:40 PM, Rachel Protacio wrote: Hi again,
Please see my updated webrev which incorporates Dmitry's suggestion to use a regex to ensure a full and proper match. Webrev: http://cr.openjdk.java.net/~coleenp/8138574.01/ Update passes jtreg. Thanks, Rachel On 9/29/2015 1:34 PM, Rachel Protacio wrote: Hello! Please review this one-character change to fix bug 8138574, where the existing test was not general enough to pass as new logging tags are added.
Summary: TestBasicLogOutput.java edited to account for padding in tag descriptors Bug: https://bugs.openjdk.java.net/browse/JDK-8138574 Webrev: http://cr.openjdk.java.net/~coleenp/8138574 Testing: passes jtreg on own and when tested with added tags Thank you, Rachel
- Previous message: RFR: JDK-8138574: [TESTBUG] TestBasicLogOutput.java doesn't account for padding
- Next message: RFR: JDK-8138574: [TESTBUG] TestBasicLogOutput.java doesn't account for padding
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]