RFR(M): 8139040: Fix initializations before ShouldNotReachHere() (original) (raw)
Lindenmaier, Goetz goetz.lindenmaier at sap.com
Wed Oct 7 13:22:05 UTC 2015
- Previous message: RFR: JDK-8136577: Make AbortVMOnException available in product builds
- Next message: RFR(M): 8139040: Fix initializations before ShouldNotReachHere()
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hi,
SAP requires us to fix a row of issues in the hotspot coding. I would like to share these with openJDK.
This webrev fixes a row of missing intializations, mostly combined with ShouldNotReachHere() in default cases of switches or the like. http://cr.openjdk.java.net/~goetz/webrevs/8139040-init/webrev.00/
In the debug build, ShouldNotReachHere() can be suppressed, so the uninitialized value actually can cause problems. In opt builds, not all tools recognize the ShouldNotReachHere properly.
In addition to this I would like to add -Wuninitialized to the warning flags. This finds most of these issues in the opt build and would require an additional 70 fixes plus fixes in jvmtiEnter.xsl. Would it be appreciated to set this flag?
Best regards, Goetz.
- Previous message: RFR: JDK-8136577: Make AbortVMOnException available in product builds
- Next message: RFR(M): 8139040: Fix initializations before ShouldNotReachHere()
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]