RFR: 8135284: Remove Method::_method_size field (original) (raw)

Yumin Qi yumin.qi at oracle.com
Tue Oct 13 00:31:36 UTC 2015

Coleen,

Thanks for the review! I will reformat the line.

Yumin

On 10/12/15, 4:35 PM, Coleen Phillimore wrote:

Hi Yumin, This looks good. Thank you for doing the extra work to clean up the SA code. + type = db.lookupType("Method");

Can you align this with the other assignment operators? thanks, Coleen On 10/12/15 6:01 PM, Yumin Qi wrote: Please review the small changes for

bug: https://bugs.openjdk.java.net/browse/JDK-8135284 webrev: http://cr.openjdk.java.net/~minqi/8135284/webrev00/ Summary: After JDK-8135085 integration, Method increased 4 bytes for 32-bit platforms(no effect for 64 bit). This change removed methodsize from Method which saved 2 bytes for Method. Deleted methodsize related code in SA. The Method size is a constant in Method Type, if it is native method then TWO words added which is consistent with hotspot code. btyecodeOffset in Method.java is no longer useful, the offset is now in ConstMethod so removed too. Tests: JPRT, Runtime Quick test list, run SA on sun.jvm.hotspot.tools.ClassLoaderStats (instrumented Method output to get size). Thanks Yumin

More information about the hotspot-runtime-dev mailing list