RFR[ 9u-dev] JDK-8075773 - jps running as root fails after the fix of JDK-8050807 (original) (raw)
Langer, Christoph christoph.langer at sap.com
Wed Oct 14 22:20:18 UTC 2015
- Previous message: RFR (S) round 0 for 8136552 Last argument wins does not work for special options with "-XX:VMOptionsFile" option
- Next message: RFR[ 9u-dev] JDK-8075773 - jps running as root fails after the fix of JDK-8050807
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hi,
Is there any particular reason why you fixed this for Posix and Linux only? I see the same issue occurring on AIX and I believe BSD will have it as well.
If not, I suggest the following fix: http://cr.openjdk.java.net/~clanger/webrevs/8075773.0/
Please review and sponsor.
This is the bug ID: https://bugs.openjdk.java.net/browse/JDK-8075773
Thanks Christoph
Hi, Thanks Dmitry and Jerry for your review comments. I have fixed the spacing and indentation issue.
Update web review link: http://cr.openjdk.java.net/~poonam/8075773/webrev.01/<http://cr.openjdk.java.net/%7Epoonam/8075773/webrev.01/>
Regards, Cheleswer
On 7/28/2015 3:13 AM, Gerald Thornbrugh wrote:
Hi Cheleswer,
Other than the issues Dimitry mentioned below your changes look good. I am also not a "Reviewer". Thanks! Jerry Cheleswer,
src/os/linux/vm/perfMemorylinux.cpp 220 space missed after // 222 space missed after != src/os/solaris/vm/perfMemorysolaris.cpp 222 extra space before // (wrong indent) Otherwise looks good. (not a Reviewer) -Dmitry
On 2015-07-27 20:07, cheleswer sahu wrote: Hi, Please review the code changes for "https://bugs.openjdk.java.net/browse/JDK-8075773" . Web review Link: http://cr.openjdk.java.net/~poonam/8075773/webrev.00/<http://cr.openjdk.java.net/%7Epoonam/8075773/webrev.00/> Bug brief: This bug was introduced after the fix of JDK-8050807. JPS reads the process information from "/tmp/hsperfdata$username$ProcessID". In order to ensure the file is secure to open and read, it tries to match the UID with the effective user ID of that file. When JPS is run as root user this check gets failed. Fix: If JPS is running as a root user, then the check which matches, UID with effective user id is skipped. I have test this fix, it's working fine and found no security issue.
Regards, Cheleswer
- Previous message: RFR (S) round 0 for 8136552 Last argument wins does not work for special options with "-XX:VMOptionsFile" option
- Next message: RFR[ 9u-dev] JDK-8075773 - jps running as root fails after the fix of JDK-8050807
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]