RFR[ 9u-dev] JDK-8075773 - jps running as root fails after the fix of JDK-8050807 (original) (raw)

Daniel D. Daugherty daniel.daugherty at oracle.com
Thu Oct 15 23:13:02 UTC 2015

On 10/15/15, 3:48 PM, Langer, Christoph wrote:

Hi Dan, Cheleswer,

yes, I'll test AIX and give feedback on Monday. Is it really necessary to open another bug for this or can't a new changeset just be added to the old bug 8075773? It is about the same issue, just other platforms...

Yes a new bug is necessary. Under OpenJDK jcheck rules, a bug ID can only be used once...

Dan

Best regards Christoph -----Original Message----- From: Daniel D. Daugherty [mailto:daniel.daugherty at oracle.com] Sent: Donnerstag, 15. Oktober 2015 15:26 To: cheleswer sahu<cheleswer.sahu at oracle.com> Cc: Langer, Christoph<christoph.langer at sap.com>; hotspot-runtime-dev at openjdk.java.net Subject: Re: RFR[ 9u-dev] JDK-8075773 - jps running as root fails after the fix of JDK-8050807 Cheleswer, The original issue needs to be tested and fixed on all of the platforms that we (Oracle) support. That includes BSD/MacOS X. Christoph, I presume that you can test an AIX specific patch for Cheleswer since I don't think we have any AIX setups in either the JPRT farm or the Aurora farm (Oracle internal). Dan On 10/15/15, 5:31 AM, cheleswer sahu wrote: Hi Christoph, I had done fixes only for those platforms which were available to me at that point of time. Thanks for reporting the issue on AIX. I will create a new Bug for this and fix this issue asap.

Regards, Cheleswer On 10/15/2015 3:50 AM, Langer, Christoph wrote: Hi, Is there any particular reason why you fixed this for Posix and Linux only? I see the same issue occurring on AIX and I believe BSD will have it as well. If not, I suggest the following fix: http://cr.openjdk.java.net/~clanger/webrevs/8075773.0/ <http://cr.openjdk.java.net/%7Eclanger/webrevs/8075773.0/> Please review and sponsor. This is the bug ID: /https://bugs.openjdk.java.net/browse/JDK-8075773/// // /Thanks/ /Christoph/

------------------------------------------------------------ Hi, Thanks Dmitry and Jerry for your review comments. I have fixed the spacing and indentation issue. Update web review link: http://cr.openjdk.java.net/~poonam/8075773/webrev.01/ <http://cr.openjdk.java.net/%7Epoonam/8075773/webrev.01/> Regards, Cheleswer On 7/28/2015 3:13 AM, Gerald Thornbrugh wrote: /Hi Cheleswer,/ // /Other than the issues Dimitry mentioned below your changes look good./ // /I am also not a "Reviewer"./ // /Thanks!/ // /Jerry/ /Cheleswer,/ // /src/os/linux/vm/perfMemorylinux.cpp/ // /220 space missed after /// /222 space missed after !=/ // /src/os/solaris/vm/perfMemorysolaris.cpp/ // /222 extra space before // (wrong indent)/ // /Otherwise looks good. (not a Reviewer)/ // /-Dmitry/ // // /On 2015-07-27 20:07, cheleswer sahu wrote:/ /Hi,/ // /Please review the code changes for/ /"//https://bugs.openjdk.java.net/browse/JDK-8075773//" ./ /Web review Link: //http://cr.openjdk.java.net/~poonam/8075773/webrev.00/ <http://cr.openjdk.java.net/%7Epoonam/8075773/webrev.00/>/// // /Bug brief: This bug was introduced after the fix of JDK-8050807. JPS/ /reads the process information from/ /"/tmp/hsperfdata$username$ProcessID". In order to ensure the file is/ /secure to open and read, it tries to match the UID with the effective/ /user ID of that file. When JPS is run as root user this check gets / /failed./ // /Fix: If JPS is running as a root user, then the check which matches, / /UID/ /with effective user id is skipped./ // /I have test this fix, it's working fine and found no security issue./ // // /Regards,/ /Cheleswer/ //

More information about the hotspot-runtime-dev mailing list