RFR: 8138916: Logging write function does not allow for long enough messages (original) (raw)
Rachel Protacio rachel.protacio at oracle.com
Mon Oct 26 20:58:46 UTC 2015
- Previous message: RFR(XS) 8140452: Internal Error memory/allocation.cpp:179
- Next message: RFR: 8138916: Logging write function does not allow for long enough messages
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hello, all,
Please review this fix to the faulty write function from the Unified Logging framework.
Summary: In logging/log.hpp, the logging vwrite function previously asserted that the buffer remains within 512 characters, which is too short for logging message of non-pre-determined length, e.g. for vtable and itable function names. Now, the function resizes the buffer to the appropriate length, asserting only that the resulting buffer is valid. Includes tag "logtest" to test that logging can print an output of 518 characters.
Open webrev: http://cr.openjdk.java.net/~rprotacio/8138916/ Bug: https://bugs.openjdk.java.net/browse/JDK-8138916
Includes own acceptance test, and passes JPRT and remote hotspot/test tests.
Thank you, Rachel
- Previous message: RFR(XS) 8140452: Internal Error memory/allocation.cpp:179
- Next message: RFR: 8138916: Logging write function does not allow for long enough messages
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]