RFR(XS, URGENT): JDK-8140663 FrameValue might be used uninitialized (original) (raw)
Bengt Rutisson bengt.rutisson at oracle.com
Thu Oct 29 12:59:46 UTC 2015
- Previous message: RFR(XS, URGENT): JDK-8140663 FrameValue might be used uninitialized
- Next message: RFR (S) 8140650: (preliminary) Method::is_accessor should cover getters and setters for all types
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On 2015-10-28 21:01, Dmitry Samersoff wrote:
Bengt,
Thank you for review. Unfortunately, the fix is already in a queue so I can't mention you in reviewers.
No problem.
Thanks for fixing this!
Bengt
-Dmitry On 2015-10-28 22:30, Bengt Rutisson wrote: Hi Dmitry,
On 2015-10-28 15:37, Dmitry Samersoff wrote: Everyone,
Please review small, non-product fix. http://cr.openjdk.java.net/~dsamersoff/JDK-8140663/webrev.01 -Dmitry I ran into this issue when I compiled with a newer version of g++. For me the only place where there was an issue was in FrameValues::validate(). The iteration in that code is a bit strange and by re-writing it a bit you could make sure that the prev value was always initialized. I think your fix is probably better and simpler. So, for me your change looks good. I just wanted to mention the other solution in case you'd prefer it. Consider your patch reviewed by me if you want to push it urgently. Thanks, Bengt
- Previous message: RFR(XS, URGENT): JDK-8140663 FrameValue might be used uninitialized
- Next message: RFR (S) 8140650: (preliminary) Method::is_accessor should cover getters and setters for all types
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]