RFR(XS): 8211364: Remove expired flags (original) (raw)

David Holmes david.holmes at oracle.com
Tue Oct 2 02:00:18 UTC 2018

Hi Mikael,

On 2/10/2018 11:16 AM, Mikael Vidstedt wrote:

Please review this change which removes expired flags. bug: https://bugs.openjdk.java.net/browse/JDK-8211364 webrev: http://cr.openjdk.java.net/~mikael/webrevs/8211364/webrev.00/open/webrev/ * Background (from the issue) A number of flags which expire(d) in jdk12 should be removed from the specialjvmflags table. * Testing tier1-3. Lots of manual grep:ing to make sure none of the flags is actually used.

All of which should have been done when the flags were obsoleted! :(

This all seems fine to me, but obviously the JFR tests were not handled when the FastTLABRefill flag was deprecated or obsoleted! Someone from JFR needs to re-examine all those tests to see if they are still testing what was expected in relation to C1, c2 and interpreter.

Aside: the ObsoleteFlagErrorMessage.java test is annoying in that it needs updating on each release to find a new "newly obsoleted" flag. :(

Thanks, David

Note: There’s one reference to InlineNotify (and SyncKnobs) in src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/GraalHotSpotVMConfigVersioned.java. I’m following up on that separately. Cheers, Mikael

More information about the hotspot-runtime-dev mailing list