RFR: 8211384: Obsolete -XX:+/-MonitorInUseLists option (original) (raw)
Roman Kennke rkennke at redhat.com
Tue Oct 2 14:50:10 UTC 2018
- Previous message: RFR: 8211384: Obsolete -XX:+/-MonitorInUseLists option
- Next message: RFR: 8211384: Obsolete -XX:+/-MonitorInUseLists option
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hi Claes,
This is a welcome change.
Some nits:
- src/hotspot/share/runtime/synchronizer.cpp:
+// deflate_thread_local_monitors() scan a single threads in-use list, while +// deflate_idle_monitors() scan only a global list of in-use monitors which
s/scan/scans/ ?
+// number of monitors in-use could negatively impacts the performance. We
s/impacts/impact/
Other than this, looks good to me.
Roman
Am 02.10.18 um 16:30 schrieb Claes Redestad:
Hi,
MonitorInUseLists was deprecated in JDK 10 and should be obsoleted. Doing this in 12 seems appropriate since it's the first in a series of non-LTS releases. Webrev: http://cr.openjdk.java.net/~redestad/8211384/jdk.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8211384 Going over the code removal for this I've tried to rewrite comments to better reflect the current behavior (+MonitorInUseLists), and took the liberty to remove some redundant ones. Testing: hs-tier1-2 Thanks! /Claes
- Previous message: RFR: 8211384: Obsolete -XX:+/-MonitorInUseLists option
- Next message: RFR: 8211384: Obsolete -XX:+/-MonitorInUseLists option
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]