RFR: 8211384: Obsolete -XX:+/-MonitorInUseLists option (original) (raw)

Daniel D. Daugherty daniel.daugherty at oracle.com
Tue Oct 2 18:02:45 UTC 2018

On 10/2/18 10:30 AM, Claes Redestad wrote:

Hi,

MonitorInUseLists was deprecated in JDK 10 and should be obsoleted. Doing this in 12 seems appropriate since it's the first in a series of non-LTS releases. Webrev: http://cr.openjdk.java.net/~redestad/8211384/jdk.00/

src/hotspot/share/runtime/arguments.cpp     No comments.

src/hotspot/share/runtime/globals.hpp     No comments.

src/hotspot/share/runtime/synchronizer.cpp     L1512: // deflate_thread_local_monitors() scans a single threads in-use list, while         Typo: "single threads in-use list" -> "single thread's in-use list"

        Very nice job on the new comment.

src/hotspot/share/runtime/synchronizer.hpp     No comments.

src/hotspot/share/runtime/thread.cpp     No comments.

Thumbs up.

Dan

Bug: https://bugs.openjdk.java.net/browse/JDK-8211384

Going over the code removal for this I've tried to rewrite comments to better reflect the current behavior (+MonitorInUseLists), and took the liberty to remove some redundant ones. Testing: hs-tier1-2 Thanks! /Claes

More information about the hotspot-runtime-dev mailing list