RFR 8211838 (XS): Minimal VM build is broken after JDK-8202951 (Implementation of JEP 341: Default CDS Archives) (original) (raw)

Volker Simonis volker.simonis at gmail.com
Mon Oct 8 08:34:51 UTC 2018

Hi Aleksey,

I've just posted a fix for this issue as well (the AIX build is broken as well).

http://mail.openjdk.java.net/pipermail/build-dev/2018-October/023559.html

Instead of checking the JVM_VARIANT, I check for ENABLE_CDS. But as far as I see, that still doesn't help for the 'minmal' variant. I think the right fix would be to set ENABLE_CDS to false for the minimal build. I could add that to my fix if you're all right with it?

Regards, Volker On Mon, Oct 8, 2018 at 9:54 AM Aleksey Shipilev <shade at redhat.com> wrote:

Bug: https://bugs.openjdk.java.net/browse/JDK-8211838 Seems like Minimal VM has CDS disabled as VM feature, which means it would fail during CDS archive generation at the end of the build. It looks like the situation Zero is in, so the quick fix is: diff -r f697ba5b18d2 make/autoconf/jdk-options.m4 --- a/make/autoconf/jdk-options.m4 Mon Oct 08 13:25:39 2018 +0800 +++ b/make/autoconf/jdk-options.m4 Mon Oct 08 09:34:16 2018 +0200 @@ -609,10 +609,11 @@ ################################################################################ # # Disable the default CDS archive generation # cross compilation - disabled # zero - off by default (not a tested configuration) +# minimal - off by default (not a tested configuration) # ACDEFUN([JDKOPTENABLEDISABLECDSARCHIVE], [ ACARGENABLE([cds-archive], [ASHELPSTRING([--disable-cds-archive], [Set to disable generation of a default CDS archive in the product image @<:@enabled@:>@])]) @@ -625,10 +626,13 @@ ACMSGRESULT([yes, forced]) BUILDCDSARCHIVE="true" elif HOTSPOTCHECKJVMVARIANT(zero); then ACMSGRESULT([no]) BUILDCDSARCHIVE="false" + elif HOTSPOTCHECKJVMVARIANT(minimal); then + ACMSGRESULT([no]) + BUILDCDSARCHIVE="false" elif test "x$enablecdsarchive" = "x"; then ACMSGRESULT([yes]) BUILDCDSARCHIVE="true" elif test "x$enablecdsarchive" = "xno"; then ACMSGRESULT([no, forced]) I think a good follow-up would be actually checking for "cds" as feature, and disabling cds-archive based on that. I think --with-jvm-features=-cds fails the same way. Testing: x8664 Minimal/Server builds Thanks, -Aleksey

More information about the hotspot-runtime-dev mailing list