RFR(S): 8211714: Need to update vm_version.cpp to recognise VS2017 minor versions (original) (raw)
Muthusamy Chinnathambi muthusamy.chinnathambi at oracle.com
Tue Oct 9 10:14:03 UTC 2018
- Previous message: RFR(S): 8211714: Need to update vm_version.cpp to recognise VS2017 minor versions
- Next message: RFR(S): 8211852: inspect stack during error reporting
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Looks fine - and trivial so only 1 review needed. Thanks for the review David.
Regards, Muthusamy C
-----Original Message----- From: David Holmes Sent: Tuesday, October 9, 2018 6:35 AM To: Muthusamy Chinnathambi <muthusamy.chinnathambi at oracle.com>; hotspot-runtime-dev at openjdk.java.net Subject: Re: RFR(S): 8211714: Need to update vm_version.cpp to recognise VS2017 minor versions
Looks fine - and trivial so only 1 review needed.
I've often wondered why MS never defined a string literal for the version so we wouldn't need this table ...
Thanks, David
On 8/10/2018 9:21 PM, Muthusamy Chinnathambi wrote:
Hi,
Please review this change to make hotspot aware of additional windows compiler versions. Bug: https://bugs.openjdk.java.net/browse/JDK-8211714 Webrev: http://cr.openjdk.java.net/~mchinnathamb/8211714/webrev.00/ Regards, Muthusamy C
- Previous message: RFR(S): 8211714: Need to update vm_version.cpp to recognise VS2017 minor versions
- Next message: RFR(S): 8211852: inspect stack during error reporting
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]