RFR: JDK-8211792: Fix misplaced BarrierSet forward declarations (original) (raw)
Zhengyu Gu zgu at redhat.com
Tue Oct 9 17:56:51 UTC 2018
- Previous message: RFR: JDK-8211792: Fix misplaced BarrierSet forward declarations
- Next message: RFR (S): 8211394: CHECK_ must be used in the rhs of an assignment statement within a block
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Looks to me too.
Thanks,
-Zhengyu
On 10/08/2018 03:49 PM, Roman Kennke wrote:
On 10/05/2018 11:46 PM, Roman Kennke wrote: In templateTable.hpp there's a forward declaration for BarrierSet missing, while in oop.hpp we have a gratituous one.
Bug: https://bugs.openjdk.java.net/browse/JDK-8211792 Webrev: http://cr.openjdk.java.net/~rkennke/JDK-8211792/webrev.00/ Looks good to me. Indeed, templateTable.hpp needs the declaration for: 97 static BarrierSet* bs; // Cache the barrier set. ...and oop.hpp does not reference BarrierSet anywhere. The transitive dependencies that get BarrierSet from oop.hpp should really get BarrierSet explicitly. I have build Linux x8664/fastdebug without PCH to make sure this does not happen now on common paths. Thanks for reviewing, Aleksey! jdk/submit came back with PASSED too. Ok to push it? Roman
- Previous message: RFR: JDK-8211792: Fix misplaced BarrierSet forward declarations
- Next message: RFR (S): 8211394: CHECK_ must be used in the rhs of an assignment statement within a block
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]