RFR 8211821: PrintStringTableStatistics crashes JVM (original) (raw)

David Holmes david.holmes at oracle.com
Wed Oct 10 21:42:29 UTC 2018


Hi Harold,

On 11/10/2018 6:44 AM, Harold David Seigel wrote:

Hi,

Please review this fix for JDK-8211821.  The change fixes the problem by moving the call to exitglobals() in Threads::destroyvm() to before the thread gets deleted.

I need to give that some very careful thought - this stuff is very fragile and a simple change can have unexpected consequences.

Thanks, David

  Although exit_globals() deletes tty, this is not a

problem because neither deleting thread nor freeing the jvmcioldthreadcounters use tty.

Open Webrev: http://cr.openjdk.java.net/~hseigel/bug8211821/webrev/ JBS Bug:  https://bugs.openjdk.java.net/browse/JDK-8211821 The fix was tested by running the new test and Mach5 tiers 1 and 2 tests and builds on Linux-x64, Windows, and Mac OS X, running tiers 3-5 tests on Linux-x64, and by running JCK-12 API, Lang and VM tests on Linux-x64. Thanks, Harold



More information about the hotspot-runtime-dev mailing list