RFR: JDK-8212053: A few more missing object equals barriers (original) (raw)
Zhengyu Gu zgu at redhat.com
Fri Oct 12 12:38:51 UTC 2018
- Previous message: RFR: JDK-8212053: A few more missing object equals barriers
- Next message: RFR (XS): 8211046: Forced data dependencies serve no purpose on x86
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Good to me.
Thanks,
-Zhengyu
On 10/11/2018 12:53 PM, Roman Kennke wrote:
Testing and code analysis have revealed a couple more places where we need oopDesc::equals() or oopDesc::equalsraw(). Those should really be the last ones (notwithstanding new code of course):
in compressed oops, we should use equalsraw() because it's only used to verify that we encoded/decoded the oop correctly a few lines above. It cannot have been changed yet. In vframe, we need the usual oopDesc::equals(..) because we may see different copies of the same object. Bug: https://bugs.openjdk.java.net/browse/JDK-8212053 Webrev: http://cr.openjdk.java.net/~rkennke/JDK-8212053/webrev.00/ Builds and runs hotspot/tier1 fine. Ok? Roman
- Previous message: RFR: JDK-8212053: A few more missing object equals barriers
- Next message: RFR (XS): 8211046: Forced data dependencies serve no purpose on x86
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]