RFR(S): 8024368: private methods are allocated vtable slots (original) (raw)
David Holmes david.holmes at oracle.com
Tue Oct 16 06:55:40 UTC 2018
- Previous message: RFR [11u]: JDK-8212100: AppCDS crashes for some uses with JRuby (back port)
- Next message: RFR(S): 8024368: private methods are allocated vtable slots
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Looks good - officially Reviewed!
Thanks for fixing Serguei!
David
On 16/10/2018 3:03 PM, serguei.spitsyn at oracle.com wrote:
Please, review a fix for: https://bugs.openjdk.java.net/browse/JDK-8024368
Webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2018/8024368-priv-vtable.2/
Summary: Private method should not allocate vtable indeces. The fix tweaks several conditions in the functions: klassVtable::updateinheritedvtable() and klassVtable::needsnewvtableentry(), adds a couple of asserts and makes several comments up-to-date. The fix was preliminary reviewed by Karen, David H. and Lois. Testing: The fix was verified with runtime/{appcds+Nestmates+RedefineTests+SelectionResolution} and vmTestbase/vm/runtime/defmeth tests. Also, I ran a mach5 job with the flags: tier1,tier2,hs-tier3,hs-tier4,hs-tier5. By suggestion from David, it was also tested with the -Xlog output for vtables before and after the fix. I've done this comparison (awk was used to get rid of the first column with the time stamps). It shows that private methods were included into vtable before the fix but not included after. Please, see one fragment as an example: 166c166 < copy vtable from java.lang.Object to java.lang.StackFrameInfo_ _size 17_ _---_ _> copy vtable from java.lang.Object to java.lang.StackFrameInfo size 16 180d179 < adding java.lang.StackFrameInfo.ensureRetainClassRefEnabled()V at_ _index 16, flags: private_ _182c181_ _< copy vtable from java.lang.StackFrameInfo to_ _java.lang.LiveStackFrameInfo size 17_ _---_ _> copy vtable from java.lang.StackFrameInfo to java.lang.LiveStackFrameInfo size 16 188,201c187,191 < copy vtable from java.lang.Object to_ _java.lang.StackStreamFactory$AbstractStackWalker size 18_ _< adding java.lang.StackStreamFactory$AbstractStackWalker.close()V_ _at index 5, flags: private_ _< adding_ _java.lang.StackStreamFactory$AbstractStackWalker.toStackWalkMode(Ljava/lang/StackWalker;I)I_ _at index 6, flags: private_ _< adding_ _java.lang.StackStreamFactory$AbstractStackWalker.consumeFrames()Ljava/lang/Object;_ _at index 7, flags: protected abstract_ _< adding_ _java.lang.StackStreamFactory$AbstractStackWalker.initFrameBuffer()V at_ _index 8, flags: protected abstract_ _< adding_ _java.lang.StackStreamFactory$AbstractStackWalker.batchSize(I)I at index_ _9, flags: protected abstract_ _< adding_ _java.lang.StackStreamFactory$AbstractStackWalker.getNextBatchSize()I at_ _index 10, flags: protected_ _< adding_ _java.lang.StackStreamFactory$AbstractStackWalker.skipReflectionFrames()Z_ _at index 11, flags: private_ _< adding_ _java.lang.StackStreamFactory$AbstractStackWalker.doStackWalk(JIIII)Ljava/lang/Object;_ _at index 12, flags: private_ _< adding_ _java.lang.StackStreamFactory$AbstractStackWalker.getNextBatch()I at_ _index 13, flags: private_ _< adding_ _java.lang.StackStreamFactory$AbstractStackWalker.beginStackWalk()Ljava/lang/Object;_ _at index 14, flags: private_ _< adding_ _java.lang.StackStreamFactory$AbstractStackWalker.fetchStackFrames(I)I at_ _index 15, flags: private_ _< adding_ _java.lang.StackStreamFactory$AbstractStackWalker.fetchStackFrames(JJII[Ljava/lang/Object;)I_ _at index 16, flags: private native_ _< adding_ _java.lang.StackStreamFactory$AbstractStackWalker.callStackWalk(JIII[Ljava/lang/Object;)Ljava/lang/Object;_ _at index 17, flags: private native_ _---_ _> copy vtable from java.lang.Object to java.lang.StackStreamFactory$AbstractStackWalker size 9 > adding java.lang.StackStreamFactory$AbstractStackWalker.consumeFrames()Ljava/lang/Object; at index 5, flags: protected abstract > adding java.lang.StackStreamFactory$AbstractStackWalker.initFrameBuffer()V at index 6, flags: protected abstract > adding java.lang.StackStreamFactory$AbstractStackWalker.batchSize(I)I at index 7, flags: protected abstract > adding java.lang.StackStreamFactory$AbstractStackWalker.getNextBatchSize()I at index 8, flags: protected Thanks, Serguei
- Previous message: RFR [11u]: JDK-8212100: AppCDS crashes for some uses with JRuby (back port)
- Next message: RFR(S): 8024368: private methods are allocated vtable slots
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]