RFR 8017061: os_bsd.cpp contains code for UseSHM and UseHugeTLBFS (original) (raw)

Gerard Ziemski gerard.ziemski at oracle.com
Tue Oct 16 16:04:18 UTC 2018

hi David,

Thank you for the review.

On Oct 16, 2018, at 1:48 AM, David Holmes <david.holmes at oracle.com> wrote:

Hi Gerard, On 16/10/2018 5:41 AM, Gerard Ziemski wrote: Hi all, Please review this small fox that removes code from bsd platform, which implements unused (and untested) UseLargePages support. Removal seems okay but I think you can also remove: ./os/bsd/globalsbsd.hpp: product(bool, UseSHM, false, ./os/bsd/globalsbsd.hpp: product(bool, UseHugeTLBFS, false,

If I remove “UseSHM” and “UseHugeTLBFS” they will stop being accepted on BSD platform, though the documentation says it’s Linux only. Would I need to obsolete them? If so, how to obsolete a flag on just one platform?

Also, in this fix, I took opportunity to cleanup OS includes (there were unused and duplicated headers) Seems mostly okay but I would have expected mach/mach.h, or mach/machtime.h, to get machtimebaseinfodatat ? Maybe it comes in indirectly from elsewhere? I poked around the devkit but couldn't isolate it.

It comes from:

#include “os_bsd.inline.hpp” #include “runtime/os.hpp” #idef APPLE #include <mach/mach_time.h> #endif

cheers

More information about the hotspot-runtime-dev mailing list