RFR 7041262: VM_Version should be called instead of Abstract_VM_Version so that overriding works (original) (raw)
Vladimir Kozlov vladimir.kozlov at oracle.com
Tue Oct 16 16:14:59 UTC 2018
- Previous message: RFR 7041262: VM_Version should be called instead of Abstract_VM_Version so that overriding works
- Next message: RFR 7041262: VM_Version should be called instead of Abstract_VM_Version so that overriding works
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Thank you. I thought all platforms implement these methods. Changes are good then.
Vladimir
On 10/15/18 5:58 PM, Kim Barrett wrote:
On Oct 15, 2018, at 6:58 PM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
Stupid question. Why keep empty static methods in AbstractVMVersion which are never used? The empty methods are the defaults, for platforms that don’t extend or override the behavior. For example, only sparc currently extends initbeforeergo. For all other platforms, the empty default is used. arm is the only implementor of earlyinitialize. It does look like every platform implements initialize, but I think the empty Abstract method should be kept for consistency, and as the place to hang the documentation comment. The thing I’m confused about is how VMVersionExt fits into this scheme. But that’s out of scope for Harold’s change, which looks good to me.
- Previous message: RFR 7041262: VM_Version should be called instead of Abstract_VM_Version so that overriding works
- Next message: RFR 7041262: VM_Version should be called instead of Abstract_VM_Version so that overriding works
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]