RFR (XS) 8212617: ARM32 build failures after JDK-7041262 (VM_Version should be called instead of Abstract_VM_Version so that overriding works) (original) (raw)

Harold David Seigel harold.seigel at oracle.com
Wed Oct 17 18:07:34 UTC 2018

Hi Aleksey,

This fix looks good and trivial.  Thanks for fixing this.

Harold

On 10/17/2018 2:02 PM, Aleksey Shipilev wrote:

Bug: https://bugs.openjdk.java.net/browse/JDK-8212617

I think it fails because there is a left-over declaration in ARM header, which makes linker try to find the definition, and failing. Fix: # HG changeset patch # User shade # Date 1539798253 -7200 # Wed Oct 17 19:44:13 2018 +0200 # Node ID 050c046ef62bdee5b78bba0beec8f04f9a63a1b1 # Parent 92a18a1292533c334021aef21a66c5c9bc1b663c 8212617: ARM32 build failures after JDK-7041262 (VMVersion should be called instead of AbstractVMVersion so that overriding works) Reviewed-by: XXX diff -r 92a18a129253 -r 050c046ef62b src/hotspot/cpu/arm/vmversionarm.hpp --- a/src/hotspot/cpu/arm/vmversionarm.hpp Wed Oct 17 19:11:11 2018 +0200 +++ b/src/hotspot/cpu/arm/vmversionarm.hpp Wed Oct 17 19:44:13 2018 +0200 @@ -110,7 +110,6 @@ static bool supportskusercmpxchg64() { return kuserhelperversion >= KUSERVERSIONCMPXCHG64; } // Override AbstractVMVersion implementation static bool usebiasedlocking(); - static const char* vminfostring(); static bool hasvfp() { return (features & vfpm) != 0; } static bool hasvfp332() { return (features & vfp332m) != 0; }

Testing: Linux arm32 build Thanks, -Aleksey

More information about the hotspot-runtime-dev mailing list