RFR 8017061: os_bsd.cpp contains code for UseSHM and UseHugeTLBFS (original) (raw)

David Holmes david.holmes at oracle.com
Thu Oct 18 01:38:22 UTC 2018

Hi Gerard,

On 18/10/2018 3:14 AM, Gerard Ziemski wrote:

Thank you for your reviews.

On Oct 16, 2018, at 6:52 PM, David Holmes <david.holmes at oracle.com> wrote:

Hi Gerard, On 17/10/2018 2:04 AM, Gerard Ziemski wrote: hi David, Thank you for the review. On Oct 16, 2018, at 1:48 AM, David Holmes <david.holmes at oracle.com> wrote:

Hi Gerard, On 16/10/2018 5:41 AM, Gerard Ziemski wrote: Hi all, Please review this small fox that removes code from bsd platform, which implements unused (and untested) UseLargePages support. Removal seems okay but I think you can also remove: ./os/bsd/globalsbsd.hpp: product(bool, UseSHM, false, ./os/bsd/globalsbsd.hpp: product(bool, UseHugeTLBFS, false, If I remove “UseSHM” and “UseHugeTLBFS” they will stop being accepted on BSD platform, though the documentation says it’s Linux only. Would I need to obsolete them? If so, how to obsolete a flag on just one platform? I think if you #ifdef the entry in the obsolete flags table that would do it. This is a rare occurrence. Obsolete in 12 and expire in 13. Fixed. Webrev: http://cr.openjdk.java.net/~gziemski/8017061rev2

The flags are obsoleted not deprecated, they should be removed from the globals_bsd.hpp file.

Thanks, David

Testing: Mach5 hstier1-6 underway…

cheers

More information about the hotspot-runtime-dev mailing list