RFR(two-liner): 8212707: GlobalCounter padding is too optimistic (original) (raw)
Robbin Ehn robbin.ehn at oracle.com
Mon Oct 22 11:06:06 UTC 2018
- Previous message: RFR(S) 8212200 assert when shared java.lang.Object is redefined by JVMTI agent
- Next message: RFR(two-liner): 8212707: GlobalCounter padding is too optimistic
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hi all, please review.
We should not divide DEFAULT_CACHE_LINE_SIZE by 2. More info in issue: https://bugs.openjdk.java.net/browse/JDK-8212707
Code: below
Sanity with T1.
Thanks, Robbin
diff -r bca2b63dd839 src/hotspot/share/utilities/globalCounter.hpp --- a/src/hotspot/share/utilities/globalCounter.hpp Mon Oct 22 14:08:07 2018 +0800 +++ b/src/hotspot/share/utilities/globalCounter.hpp Mon Oct 22 11:48:17 2018 +0200 @@ -48,1 +48,1 @@
- DEFINE_PAD_MINUS_SIZE(0, DEFAULT_CACHE_LINE_SIZE/2, 0);
- DEFINE_PAD_MINUS_SIZE(0, DEFAULT_CACHE_LINE_SIZE, 0);
@@ -50,1 +50,1 @@
- DEFINE_PAD_MINUS_SIZE(1, DEFAULT_CACHE_LINE_SIZE/2, sizeof(volatile uintx));
- DEFINE_PAD_MINUS_SIZE(1, DEFAULT_CACHE_LINE_SIZE, sizeof(volatile uintx));
- Previous message: RFR(S) 8212200 assert when shared java.lang.Object is redefined by JVMTI agent
- Next message: RFR(two-liner): 8212707: GlobalCounter padding is too optimistic
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]