RFR(S) : 8177710 : Convert TestMetaspaceUtils_test to GTest (original) (raw)

Igor Ignatyev igor.ignatyev at oracle.com
Mon Oct 29 21:06:59 UTC 2018

Hi Thomas,

thanks for your reviews. I've also noticed problems in virtual_space_list_large_chunk test (including the leak) and am going to file an RFE to improve the test.

Cheers, -- Igor

On Oct 29, 2018, at 1:10 AM, Thomas Schatzl <thomas.schatzl at oracle.com> wrote:

Hi Igor, On Fri, 2018-10-26 at 16:22 -0700, Igor Ignatyev wrote: http://cr.openjdk.java.net/~iignatyev//8177710/webrev.00/index.html

85 lines changed: 84 ins; 1 del; 0 mod;

Hi all, could you please review this small and trivial patch which converts TestMetaspaceUtilstest[1] to Gtest? old tests hasn't been removed as it's still used by WhiteBox::runMemoryUnitTests, it will be handled separately. webrev: http://cr.openjdk.java.net/~iignatyev//8177710/webrev.00/index.html JBS: https://bugs.openjdk.java.net/browse/JDK-8177710 [1] looks good. There is a pre-existing memory leak: in the virtualspacelistlargechunk() method the VirtualSpaceList is never deleted. Maybe this can be fixed, possibly in a different CR, or maybe this is intentional. Thanks, Thomas

More information about the hotspot-runtime-dev mailing list