RFR(S): 8213000: Obsolete the IgnoreUnverifiableClassesDuringDump vm option (original) (raw)

David Holmes david.holmes at oracle.com
Wed Oct 31 01:29:09 UTC 2018

Hi Calvin,

Looks good.

Only comment is whether the test should be looking for output that confirms the non-verifiable class was found and elided from the archive?

Thanks, David

On 31/10/2018 9:58 AM, Calvin Cheung wrote:

On 10/30/18, 4:21 PM, Jiangli Zhou wrote: Hi Calvin,

The change looks good, except the remaining use of -IgnoreUnverifiableClassesDuringDump, which is also brought up in the closed review. Thanks for your review. I've updated the VerifierTest.java test in the following updated webrev: http://cr.openjdk.java.net/~ccheung/8213000/webrev.01/ thanks, Calvin Thanks, Jiangli

On 10/30/18 3:31 PM, Calvin Cheung wrote: bug: https://bugs.openjdk.java.net/browse/JDK-8213000 webrev: http://cr.openjdk.java.net/~ccheung/8213000/webrev.00/ Please review this change for obsoleting the diagnostic IgoreUnverifiableClassesDuringDump vm option in JDK12. With the change, if the option is specified in the command line, the user will see the following message: Java HotSpot(TM) 64-Bit Server VM warning: Ignoring option IgnoreUnverifiableClassesDuringDump; support was removed in 12.0 Testing: Ran all CDS and AppCDS tests locally on linux-x64. hs-tier{1,2,3} testing in progress. thanks, Calvin

More information about the hotspot-runtime-dev mailing list