RFR: 8195685: AArch64: AArch64 cannot build with JDK-8174962 (original) (raw)

Andrew Dinn adinn at redhat.com
Sat Jan 20 11:54:53 UTC 2018

On 19/01/18 18:48, Andrew Haley wrote:

On 19/01/18 18:24, Andrew Dinn wrote:

issue: https://bugs.openjdk.java.net/browse/JDK-8195685 webrev: http://cr.openjdk.java.net/~adinn/8195685/webrev

The patch applies cleanly to jdk10 and really needs to be pushed in before it is frozen as it is a complete show-stopper for the AArch64 port. Quick reviews would be welcome. Looks OK, thanks.

Thank you for the review.

BTW, shouldn't I be in the webrev as the author? It looks very much like my jdk8 patch. :-) Yes indeed it is essentially your patch. I actually went through each of the x86 changes myself making corrections line by line and -- lo and behold -- produced exactly the same result for jdkdev/jdk, jdk10 and jdk9 (call me Pierre Menard, author of the Quixote). I admit I may possibly have had your jdk8 patch beside me for reference :-)

regards,

Andrew Dinn

Senior Principal Software Engineer Red Hat UK Ltd Registered in England and Wales under Company Registration No. 03798903 Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander

More information about the jdk-dev mailing list