New project: getting rid of IcedTea local patches (original) (raw)

Alan Bateman Alan.Bateman at Sun.COM
Thu Apr 9 12:08:55 PDT 2009

Andrew John Hughes wrote:

:

icedtea-bytebuffer-compact.patch - this looks to be a partial fix to 6593946. If so, 6593946 is already in jdk6/jdk6/jdk (http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/3e7bfcdcf96f).

IcedTea6 is still based on the last build drop of jdk6, not the Mercurial repository. So this 6 week old patch won't be in the 25th of November b14 tarball. Interestingly, it also still exists in IcedTea7 as there were cases covered by the patch which didn't make it into the commit. I've attached that version. It was originally added by Keith Seitz while he was working on OpenJDK at Red Hat (according to the ChangeLog). Once the fix gets into a build (b16?) then I don't think you'll need the IcedTea6 patch. Also, it does seem that the IcedTea6 patch is only a partial fix in that I don't see the changes for the view buffers. I looked at the patch you attached in the last mail (is this the IcedTea patch to jdk7?). It seems to be a no-op, or at least just replaces setting of mark to -1 with calls to discardMark that does the same thing. Nothing wrong with it, just inconsistent with the existing code.

-Alan.

More information about the jdk6-dev mailing list