Need reviewer: jaxp source drop update, a few fixes (original) (raw)

Joe Darcy joe.darcy at oracle.com
Mon Jun 7 20:24:06 PDT 2010

Kelly O'Hair wrote:

On Jun 7, 2010, at 9:45 AM, Joe Darcy wrote:

Kelly O'Hair wrote:

On Jun 7, 2010, at 9:06 AM, Joe Darcy wrote:

Hi Kelly.

Kelly O'Hair wrote:

Need reviewer, 3 fixes here: 6955301: Update names and references to rebranded drop bundles (jaxp, jaxws, jaf) 6940241: Change jaxp/jaxws so that the http downloads are not done by default 6955292: Workaround ant 1.7.1 package-info.java issue in ant scripts http://cr.openjdk.java.net/~ohair/openjdk6/jaxp-b20-drop/webrev/ <http://cr.openjdk.java.net/%7Eohair/openjdk6/jaxp-b20-drop/webrev/> The new jaxp drop file will be: https://jaxp.dev.java.net/files/documents/913/150648/jaxpsrc.bundle.name=jdk6-jaxp-b20.zip

On 6940241, by default, the source drop bundle will NOT be downloaded unless the ant property allow.downloads=true is defined, so you have to explicitly allow this. The env var ALTDROPSDIR or ant property drops.dir should refer to the directory holding the downloaded jaxp/jaxws source drop bundles. Before approving this, I want to understand the impact on the build logistics with 6940241. In particular, what happens if: * A fresh hg fclone is done and a "make" command is issued from the root directory? Same as before, but unless you somehow set allow.downloads=true it will never reach out via the website for a download. So does the build then fail if the bundles aren't present? If this was a fresh cloned forest, yes. If you had built it once before, the bundles persists in the jaxp//jaxws repo areas until someone purges it with a 'make clobber' or 'ant clobber' or 'hg purge'. The 'clean' rules will not purge these files or bundles. * If allow.downloads is made true, do subsequent builds always download or do they first check for a matching file in the build directory? Regardless of the setting, priority is always given to the drops.dir or ALTDROPSDIR setting, which defaults to /java/devtools/share/jdk6-drops. If it can find a copy on a file system, that is always preferred. Only if the file system copy does not exist does it try to download from the website. Okay. From the top level, how does one override all the relevant settings? Basically, I want to know how to do a successful OpenJDK 6 build from scratch on my laptop when it is disconnected from the company network :-) make ANTOPTIONS="-Dallow.downloads=true" Or as Jon suggested, download and save the jaxp/jaxws bundles in some dir, and use: make ALTDROPSDIR=somepath And ANTOPTIONS and ALTDROPSDIR can be set in your environment too. Jon is correct, I need a sanity or better error message to explain that when the download is not done or fails. I will look into that. Is the above acceptable? -kto -Joe

Some tweaks to the change are in progress and will be sent around for review when ready.

-Joe

More information about the jdk6-dev mailing list