Request to backport: JavaFileManager (original) (raw)

Jonathan Gibbons jonathan.gibbons at oracle.com
Tue Jun 22 14:46:27 PDT 2010

Joe,

I would like to backport the current JavaFileManager from JDK 7 to JDK 6.

Because of all the other work in JDK7, it is not possible to automatically backport the individual changesets. Instead, I have identified all the changesets of interest (see below), copied across the filemanager code almost exactly as-is (I had to comment out some @Override annotations), and then cherry picked the necessary edits from the various changesets to make everything work. Finally, I have gone back through the original reviews done for JDK7 to make sure that no edits of interest have been omitted.

Altogether, this addresses the following set of 19 issues:

6410637: Make decision on deprecated methods in DefaultFileManager and BaseFileObject. 6419701: DefaultFileManager clean up: URI.create 6483788: DefaultFileManager.ZipFileObject.toUri() fails to escape space characters 6501502: JSR 199: FileObject.toUri should return file:///c:/ or file:/c:/ not file://c:/ 6508981: cleanup file separator handling in JavacFileManager 6625520: javac handles missing entries on classpath badly 6705935: javac reports path name of entry in ZipFileIndex incorectly 6705945: com.sun.tools.javac.zip files do not have valid copyright 6714364: refactor javac File handling code into new javac.file package 6714365: refactor JavacFileManager to move nested classes to top level 6743107: clean up use of static caches in file manager 6794582: javadoc should read files using a FileManager 6832154: refactor Paths to be just a utility class for JavacFileManager 6838467: JSR199 FileObjects don't obey general contract of equals. 6877206: JavaFileObject.toUri returns bogus URI (win) 6877223: tests @ignored because of issues with File.toURI on Windows 6885123: JavaFileObject getName issues 6907660: stupid typo in ZipFileIndex guarantees NPE 6930076: "null" can incorrectly appear in error message compiler.err.error.reading.file

The changesets in question are:

changeset: 36:65a447c75d4b user: jjg date: Thu May 22 17:40:53 2008 -0700 summary: 6705935: javac reports path name of entry in ZipFileIndex incorectly

changeset: 46:b9bcea8bbe24 user: jjg date: Mon Jun 16 13:28:00 2008 -0700 summary: 6714364: refactor javac File handling code into new javac.file package

changeset: 47:f9a4b9e1a521 user: jjg date: Tue Jun 17 10:44:32 2008 -0700 summary: 6625520: javac handles missing entries on classpath badly

changeset: 48:aa67a5da66e3 user: jjg date: Wed Jun 18 07:23:25 2008 -0700 summary: 6714365: refactor JavacFileManager to move nested classes to top level

changeset: 99:e571266ae14f user: jjg date: Tue Aug 26 14:52:59 2008 -0700 summary: 6508981: cleanup file separator handling in JavacFileManager

changeset: 101:ceaa6549687a user: jjg date: Wed Sep 03 10:46:25 2008 -0700 summary: 6743107: clean up use of static caches in file manager

changeset: 192:1bf037016426 user: jjg date: Tue Jan 20 15:17:45 2009 -0800 summary: 6794582: javadoc should read files using a FileManager

changeset: 275:4ce1c1400334 user: jjg date: Tue May 19 15:07:15 2009 -0700 summary: 6832154: refactor Paths to be just a utility class for JavacFileManager

changeset: 399:35e29f51a7c3 user: jjg date: Tue Sep 08 11:12:13 2009 -0700 summary: 6419701: DefaultFileManager clean up: URI.create

changeset: 411:49359d0e6a9c user: jjg date: Wed Sep 23 18:48:13 2009 -0700 summary: 6410637: Make decision on deprecated methods in DefaultFileManager and BaseFileObject.

changeset: 420:86b773b7cb40 user: jjg date: Wed Oct 14 15:41:28 2009 -0700 summary: 6838467: JSR199 FileObjects don't obey general contract of equals.

changeset: 442:ea89c5d4af08 user: jjg date: Mon Dec 07 14:35:07 2009 -0800 summary: 6907660: stupid typo in ZipFileIndex guarantees NPE

changeset: 490:16b9b7f45933 user: darcy date: Wed Feb 17 14:30:17 2010 -0800 summary: 6927061: Refactor apt implemenation to use code from JSR 269

changeset: 506:72833a8a6086 user: jjg date: Fri Feb 26 15:26:58 2010 -0800 summary: 6930076: "null" can incorrectly appear in error message compiler.err.error.reading.file

-- Jon

More information about the jdk6-dev mailing list