Code Review Request : 7011591 JDWP socket transport should restart interrupted system calls (EINTR) (original) (raw)
Daniel D. Daugherty daniel.daugherty at oracle.com
Thu Aug 4 09:19:10 PDT 2011
- Previous message: Code Review Request : 7011591 JDWP socket transport should restart interrupted system calls (EINTR)
- Next message: Code Review Request : 7011591 JDWP socket transport should restart interrupted system calls (EINTR)
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On 8/4/11 9:50 AM, Alan Bateman wrote:
David Buck wrote:
Hi!
I would like to request that my fix for 7011591 be reviewed for push into JDK8 (and JDK7u if possible). CR: 7011591 JDWP socket transport should restart interrupted system calls (EINTR) : Webrev: http://cr.openjdk.java.net/~dbuck/7011591/webrev.00/ I've added serviceability-dev to the CC list as that is where the debugger code is.
Alan, thanks for adding in serviceability-dev...
Thumbs up from me since this matches my earlier reviews.
I looked at the webrev and it mostly looks okay to me. One issue is that dbgsysPoll probably should adjust the timeout when interrupted.
Adjust it how? (Just curious)
A minor nit is that you've changed the copyright date on the file from 1998 to 1997.
Don't know how I missed that with the earlier reviews, but the Teamware history shows that the earliest date for this file is indeed in 1998 and not 1997:
$ sccs prs -r1.1 src/solaris/transport/socket/socket_md.c src/solaris/transport/socket/SCCS/s.socket_md.c:
D 1.1 98/11/21 21:20:56 gordonh 1 0 00149/00000/00000 MRs: COMMENTS:
Dan
- Previous message: Code Review Request : 7011591 JDWP socket transport should restart interrupted system calls (EINTR)
- Next message: Code Review Request : 7011591 JDWP socket transport should restart interrupted system calls (EINTR)
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]