Code Review Request for MacOS X build change (7117748) (original) (raw)

Paul Hohensee paul.hohensee at oracle.com
Tue Dec 6 07:02:14 PST 2011

[dropped some of the cc's inadvertently]

If you push directly to jdk7u-osx/hotspot, and then we pull hs23 with the identical fix down into it, we'll have a conflict. Current process is to push up to hsx/hsx23, PIT over the weekend and push the following week. In this case, that'd be next week. So, do you really, really have to push this change into jdk7u-osx/hotspot right now? E.g., could you publish a patch instead as Mike has done?

Paul

On 12/6/11 9:53 AM, Daniel D. Daugherty wrote:

Paul,

I'd like to push this fix to the jdk7u/jdk7u-osx/hotspot repo. The fix is in the JPRT-hotspotwest queue heading to RTBaseline and I have it setup so that the same changeset can also go into the jdk7u/jdk7u-osx/hotspot repo. Do I have permission? Dan

On 12/3/11 9:13 PM, Daniel D. Daugherty wrote: Greetings,

I have a fix that allows HSX-23 to be built on MacOS X via JPRT without specifying SAAPPLEBOOTJAVA or ALWAYSPASSTESTGAMMA on the command line. I'm targeting this fix at RTBaseline for the HSX-23-B08 snapshot. Here is the webrev URL: http://cr.openjdk.java.net/~dcubed/7117748-webrev/0/ I tested this fix with the default JPRT boot JDK (JDK6 from Apple) and with JDK7 boot JDK (JDK7 bits from Oracle). Thanks, in advance, for any reviews. Dan P.S. This fix does not get "gamma" working on MacOS X. That work is being done separately.

More information about the jdk7u-dev mailing list