[7u4] Request for approval for 7124627 (original) (raw)

[7u4] Request for approval for 7124627 - Please sync up changes from workspace macosx-port into the jdk7u-osx

David Holmes david.holmes at oracle.com
Fri Dec 23 13:59:28 PST 2011

Hi Kumar,

FYI there are numerous changes in the osx code that I do not think should go into the mainline repositories in their current form. However this is only bringing the code from the macosx-port repo into the jdk7u-osx repo and so we don't need to address those issues right now.

They do all need to be addressed before any further osx code is merged into the mainline repos for 8 or 7u.

Cheers, and Happy Holidays David

On 24/12/2011 3:49 AM, Kumar Srinivasan wrote:

Launcher changes: I am not very happy about using #ifdef's in java.c we had taken steps to ensure that all platform dependent code, be removed from src/share/bin/java.c but it is unfortunate to see conditionals have crept in. My recommendation is to have SplashScreen as it is, but for Macos have an empty implementation, add a new function SpashScreenMacOS or something in javamd.c which will do all the necessary Mac specific items, and try to move much as possible the MacOS dependent code into javamd.c The current state of javamd.c is unmaintainable, I am planning on refactoring this code, as a separate effort, I will send a webrev once I am done. Kumar ----- alexander.zuev at oracle.com wrote:

From: alexander.zuev at oracle.com To: jdk7u-dev at openjdk.java.net, macosx-port-dev at openjdk.java.net Sent: Friday, December 23, 2011 6:55:42 AM GMT -08:00 US/Canada Pacific Subject: [7u4] Request for approval for 7124627 - Please sync up changes from workspace macosx-port into the jdk7u-osx

Hi, this is a request to sync up all the work done in the macosx-port workspace since last merge into the jdk7u-osx one. There were external review done by contributors of the project on public alias and all the found glitches were resolved so i assume that external review is finished positively. Webrevs can be found at: http://cr.openjdk.java.net/~kizune/mergejdku7/webrev.01/ Thanks, Alexander Zuev.

More information about the jdk7u-dev mailing list