Request for approval for CR 6476261 (original) (raw)

Request for approval for CR 6476261 - (reflect) GenericSignatureFormatError When signature includes nested inner classes

Dalibor Topic dalibor.topic at oracle.com
Fri Sep 2 06:09:37 PDT 2011

On 9/1/11 1:11 PM, Joe Darcy wrote:

Hello.

I hereby request approval to backport a trio of signature parsing fixes from JDK 8 to 7 update: 6476261: (reflect) GenericSignatureFormatError When signature includes nested inner classes http://bugs.sun.com/bugdatabase/viewbug.do?bugid=6476261 6832374: (reflect) malformed signature can cause parser to go into infinite loop http://bugs.sun.com/bugdatabase/viewbug.do?bugid=6832374 7052898: (reflect) SignatureParser will accept strings outside of the grammar http://bugs.sun.com/bugdatabase/viewbug.do?bugid=7052898

Unfortunately, the last bug comes up as not available for me. Could you describe it in your own words, and let us know whether this is a regression, and what its priority is?

Webrev: http://cr.openjdk.java.net/~darcy/6476261.0/

The code for 7 update is trivially different than the code for JDK 8 since the JDK 8 code takes advantage of a new constructor added to GenericSignatureFormatError; here is the diff to SignatureParser.java: 123,126c123,124 < if (DEBUG) < System.out.println("Signature Parse error: " + errorMsg + < "\n\tRemaining input: " + remainder()); < return new GenericSignatureFormatError(); --- return new GenericSignatureFormatError("Signature Parse error: " + errorMsg + "\n\tRemaining input: " + remainder());

Thanks - I am a bit puzzled since the new jdk 8 constructor seems to still be used in the posted webrev.

cheers, dalibor topic

Oracle <http://www.oracle.com> Dalibor Topic | Java F/OSS Ambassador Phone: +494023646738 tel:+494023646738 | Mobile: +491772664192 tel:+491772664192 Oracle Java Platform Group

ORACLE Deutschland B.V. & Co. KG | Nagelsweg 55 | 20097 Hamburg

ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 München Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Geschäftsführer: Jürgen Kunz, Marcel van de Molen, Alexander van der Ven

Green Oracle <http://www.oracle.com/commitment> Oracle is committed to developing practices and products that help protect the environment

More information about the jdk7u-dev mailing list