Request for approval: 7142596 RMI JPRT tests are failing (original) (raw)

Darryl Mocek darryl.mocek at oracle.com
Thu Aug 9 10:57:40 PDT 2012

All three changesets have conflicts when being applied to jdk7.
Considering all three changesets need to be modified anyway, should they be applied together or separately?

Darryl

On Tue 07 Aug 2012 03:40:21 PM PDT, Stuart Marks wrote:

OK. As one of reviewers for all of these changes, and as the one who'll do the actual push, I guess this is a reasonable way to go.

Darryl, do the individual changesets all apply cleanly? If so I can just export them from jdk8 myself and apply them to jdk7u and then push them. Or, let me know if you'd like me to proceed differently. Also, please create subCRs for each of the four affected bugs. Thanks. s'marks On 8/7/12 6:23 AM, Seán Coffey wrote: Approved for jdk7u-dev.

Like Alan mentioned, probably best to "hg export"/"hg import" the changesets and keep jdk7u/8 changes in this area similar. That involves creating a 7u8 bug record 7184943, 7184946 & 7186111 also. regards, Sean. On 07/08/2012 10:06, Alan Bateman wrote: On 06/08/2012 20:14, Darryl Mocek wrote: Hello all,

please review this backport the fix of bug 7142596 for JDK7. Bug:http://bugs.sun.com/viewbug.do?bugid=7142596 <http://bugs.sun.com/viewbug.do?bugid=7084560> This change includes 3 changesets from JDK8: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b6f78869c66d http://hg.openjdk.java.net/jdk8/tl/jdk/rev/89129c0737f1 http://hg.openjdk.java.net/jdk8/tl/jdk/rev/018e555a7a07 Here are the threads where they were reviewed: http://mail.openjdk.java.net/pipermail/core-libs-dev/2012-July/010772.html http://mail.openjdk.java.net/pipermail/core-libs-dev/2012-July/010910.html http://mail.openjdk.java.net/pipermail/core-libs-dev/2012-July/010940.html I can't tell if you are planning to push one change-set or three but I think it would be better to transplant all 3 three rather than collapsing it into one change-set + bugID (just makes it easier to compare 7u vs. 8 and makes the bug archeology easier). -Alan.

More information about the jdk7u-dev mailing list