hg: jdk7u/jdk7u-dev/langtools: 7112427: The doclet needs to be able to generate JavaFX documentation. (original) (raw)

Andrew Hughes ahughes at redhat.com
Tue Sep 4 05:55:26 PDT 2012

----- Original Message -----

Thank you for raising this issue. I will check it out.

Thanks.

This was reviewed internally for 7u, and has not yet been approved or ported forward to 8.

For future reference, it does say "Changes considering development in OpenJDK MUST be publicly discussed on the jdk7u-dev mailing list prior to approval to allow for public feedback." - http://openjdk.java.net/projects/jdk7u/groundrules.html

-- Jon >> On 09/03/2012 05:53 AM, Andrew Hughes wrote: > ----- Original Message ----- >> Changeset: b020b7a017cc >> Author: jjg >> Date: 2012-05-15 17:47 -0700 >> URL: >> http://hg.openjdk.java.net/jdk7u/jdk7u-dev/langtools/rev/b020b7a017cc >> >> 7112427: The doclet needs to be able to generate JavaFX >> documentation. >> Reviewed-by: jjg >> Contributed-by: jan.valenta at oracle.com >> >> ! >> src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java >> ! >> src/share/classes/com/sun/tools/doclets/formats/html/PackageFrameWriter.java >> + >> src/share/classes/com/sun/tools/doclets/formats/html/PropertyWriterImpl.java >> ! >> src/share/classes/com/sun/tools/doclets/formats/html/WriterFactoryImpl.java >> ! >> src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlConstants.java >> ! >> src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlWriter.java >> ! >> src/share/classes/com/sun/tools/doclets/formats/html/resources/standard.properties >> ! >> src/share/classes/com/sun/tools/doclets/internal/toolkit/Configuration.java >> + >> src/share/classes/com/sun/tools/doclets/internal/toolkit/PropertyWriter.java >> ! >> src/share/classes/com/sun/tools/doclets/internal/toolkit/WriterFactory.java >> ! >> src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/BuilderFactory.java >> ! >> src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ClassBuilder.java >> ! >> src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/MemberSummaryBuilder.java >> ! >> src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/PackageSummaryBuilder.java >> + >> src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/PropertyBuilder.java >> ! >> src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/doclet.xml >> ! >> src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/doclets.properties >> + >> src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/BasePropertyTaglet.java >> + >> src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ExpertTaglet.java >> + >> src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/PropertyGetterTaglet.java >> + >> src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/PropertySetterTaglet.java >> ! >> src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletManager.java >> ! >> src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletWriter.java >> ! >> src/share/classes/com/sun/tools/doclets/internal/toolkit/util/ClassTree.java >> ! >> src/share/classes/com/sun/tools/doclets/internal/toolkit/util/IndexBuilder.java >> ! >> src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Util.java >> ! >> src/share/classes/com/sun/tools/doclets/internal/toolkit/util/VisibleMemberMap.java >> + test/com/sun/javadoc/testJavaFX/C.java >> + test/com/sun/javadoc/testJavaFX/D.java >> + test/com/sun/javadoc/testJavaFX/TestJavaFX.java >> >> > I don't see any review for this patch, either for 8 or 7u. Can you > please provide > a link to where it was reviewed? > > This patch breaks building 7u with 6, as it doesn't include: > > changeset: 765:90af8d87741f > parent: 757:bcbc86cc5b31 > user: bpatel > date: Wed Dec 01 11:02:38 2010 -0800 > summary: 6851834: Javadoc doclet needs a structured approach to > generate the output HTML. > > specifically the class HtmlConstants: > > build-bootstrap-doclets: > [javac] Compiling 7 source files to > /home/andrew/builder/icedtea-jdk7/langtools/build/bootstrap/classes > [javac] _> /home/andrew/projects/openjdk/upstream/icedtea7/langtools/src/share/classes/com/sun/tools/doclets/formats/html/Prop_ > ertyWriterImpl.java:55: cannot find symbol > [javac] symbol : variable STARTOFPROPERTYSUMMARY > [javac] location: class > com.sun.tools.doclets.formats.html.markup.HtmlConstants > [javac] > memberSummaryTree.addContent(HtmlConstants.STARTOFPROPERTYSUMMARY); > [javac] ^ > [javac] _> /home/andrew/projects/openjdk/upstream/icedtea7/langtools/src/share/classes/com/sun/tools/doclets/formats/html/Prop_ > ertyWriterImpl.java:66: cannot find symbol > [javac] symbol : variable STARTOFPROPERTYDETAILS > [javac] location: class > com.sun.tools.doclets.formats.html.markup.HtmlConstants > [javac] > memberDetailsTree.addContent(HtmlConstants.STARTOFPROPERTYDETAILS); > [javac] ^ > [javac] _> /home/andrew/projects/openjdk/upstream/icedtea7/langtools/src/share/classes/com/sun/tools/doclets/formats/html/Prop_ > ertyWriterImpl.java:70: cannot find symbol > [javac] symbol : variable propertyDetailsLabel > [javac] location: class > com.sun.tools.doclets.formats.html.SubWriterHolderWriter > [javac] writer.propertyDetailsLabel); > [javac] ^ > [javac] _> /home/andrew/projects/openjdk/upstream/icedtea7/langtools/src/share/classes/com/sun/tools/doclets/formats/html/Prop_ > ertyWriterImpl.java:159: cannot find symbol > [javac] symbol : variable PROPERTIES > [javac] location: class > com.sun.tools.doclets.internal.toolkit.util.VisibleMemberMap > [javac] return VisibleMemberMap.PROPERTIES; > [javac] ^ > [javac] _> /home/andrew/projects/openjdk/upstream/icedtea7/langtools/src/share/classes/com/sun/tools/doclets/formats/html/Prop_ > ertyWriterImpl.java:237: cannot find symbol > [javac] symbol : method _> getDocLink(int,com.sun.javadoc.ClassDoc,com.sun.javadoc.MemberDoc,java.lang.String,boolean,boolean_ > ) > [javac] location: class > com.sun.tools.doclets.formats.html.SubWriterHolderWriter > [javac] writer.getDocLink(context, > [javac] ^ > [javac] _> /home/andrew/projects/openjdk/upstream/icedtea7/langtools/src/share/classes/com/sun/tools/doclets/formats/html/Prop_ > ertyWriterImpl.java:255: cannot find symbol > [javac] symbol : method getJavafxJavadoc() > [javac] location: class > com.sun.tools.doclets.internal.toolkit.Configuration > [javac] > ((member.name().lastIndexOf("Property") != > -1) && Configuration.getJavafxJavadoc()) > [javac] > ^ > [javac] > ^ > [javac] _> /home/andrew/projects/openjdk/upstream/icedtea7/langtools/src/share/classes/com/sun/tools/doclets/formats/html/Prop_ > ertyWriterImpl.java:254: cannot find symbol > [javac] symbol : method _> getDocLink(int,com.sun.javadoc.ClassDoc,com.sun.javadoc.MemberDoc,java.lang.String,boolean,boolean_ > ) > [javac] location: class > com.sun.tools.doclets.formats.html.SubWriterHolderWriter > [javac] > writer.getDocLink(LinkInfoImpl.CONTEXTMEMBER, > cd, (MemberDoc)member, > [javac] ^ > [javac] _> /home/andrew/projects/openjdk/upstream/icedtea7/langtools/src/share/classes/com/sun/tools/doclets/internal/toolkit/_ > builders/PropertyBuilder.java:99: cannot find symbol > [javac] symbol : variable PROPERTIES > [javac] location: class > com.sun.tools.doclets.internal.toolkit.util.VisibleMemberMap > [javac] VisibleMemberMap.PROPERTIES, > [javac] ^ > [javac] 8 errors > >

Andrew :)

Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com)

PGP Key: 248BDC07 (https://keys.indymedia.org/) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07

More information about the jdk7u-dev mailing list