Request for approval: 7152519, 7159041, 7153343 Remove including of non-POSIX header link.h (original) (raw)

Neil Richards neil.richards at ngmr.net
Tue Sep 4 08:02:53 PDT 2012

Now pushed to jdk7u-dev/jdk [1] [2] [3].

Regards, Neil

[1] http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/f8acc3222383 [2] http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/aa04907cb729 [3] http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/257dee3bea4e

On Mon, 2012-09-03 at 11:53 +0100, Seán Coffey wrote:

one approval request for these 3 related issues should be fine. Approved for jdk7u-dev. I've created bug records for all and will update when I see your pushes. As Alan said, 3 changesets will be best and I think that's your intention already.

cc'ing the original jdk8 reviewers here also as an FYI. regards, Sean. On 03/09/2012 09:28, Jonathan Lu wrote: > On 09/03/2012 04:20 PM, Alan Bateman wrote: >> On 03/09/2012 09:09, Jonathan Lu wrote: >>> Hi all, >>> >>> Here's a request of porting the fix 7152519, 7159041, 7153343 to >>> JDK7, could you please help to review? >>> >>> All the three patches serves for the same purpose of removing >>> including of non-POSIX header link.h, so I suggest to contribute >>> them in one commit. >> I don't know if there is an agreed policy on this but I think it >> would be better to just hg export/import the individual change-sets, >> otherwise it can be confusing when comparing the history or doing bug >> archeology. >> >> -Alan >> > Hi Alan, > > Sorry for the confusion, I think you are right, here I'm posting the > independent 3 change sets, BTW, is it appropriate to raise one back > port request for these three changes? > > 7152519: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/604067ec3ced > 7159041: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/9383a3749940 > 7153343: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/c4e66dc3222d > > Thanks & best regards > Jonathan > >

-- Unless stated above: IBM email: neil_richards at uk.ibm.com IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU

More information about the jdk7u-dev mailing list