Request for approval: 7190219 (bf) CharBuffer.put(String, int, int) modifies position even if BufferOverflowException thrown (original) (raw)

Jonathan Lu luchsh at linux.vnet.ibm.com
Tue Sep 4 19:16:03 PDT 2012

Thanks a lot for all your support.

Best regards Jonathan

On 09/05/2012 12:29 AM, Neil Richards wrote:

Thanks for the re-affirmation.

Now pushed to jdk7u-dev/jdk [1]. Regards, Neil [1] http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/5209ecd67995 On Tue, 2012-09-04 at 14:07 +0100, Alan Bateman wrote: On 04/09/2012 13:55, Seán Coffey wrote:

Hey Neil,

I wouldn't regard this as a risky fix and don't see a problem with it going into jdk7u-dev now (before phase2 approval process begins in mid September) It also benefits from having a unit testcase. Testing (jtreg tests) in the jdk8/tl repos would have occurred on a regular basis also since the fix was push there. Alan was initial reviewer and may wish to comment (cc'ed) No objection from me. I assume the motivation is just keeping the code in sync rather than something else. I think Lana is in process of getting the change-sets from the group forests into jdk8/jdk8. -Alan

More information about the jdk7u-dev mailing list